Dear Lukasz,
Am 16.03.22 um 13:03 schrieb Lukasz Florczak:
Thanks for reviewing my patch.
Thank you for your reply.
On Tue, 15 Mar 2022 13:39:25 +0100, Paul Menzel wrote:
Am 15.03.22 um 09:55 schrieb Lukasz Florczak:
It’d be great if you removed the dot/period at the end of the git
commit message summaries [1]. (Also in second patch.)
Noted.
Default config file location could differ depending on OS (e.g.
Debian family).
What is it an Debian?
Could you elaborate?
Sorry, I meant what is the location/path in Debian based systems, and
what is the configured path before your patch.
[...]
Looks like an independent fix. Please separate into a separate commit.
It's just adding a missing option. I don't think that it deserves a
separate commit. How about I will update the commit body to include
this particular change?
Git makes it easy to handle small commits, so I favor two commits also
because it wouldn’t be lost in case of a revert. But I have no say in
the project, and opinions differ, so it’s just an opinion.
[…]
Kind regards,
Paul
