On Wed, 19 Jan 2022 08:22:14 -0500
Jes Sorensen <jes@xxxxxxxxxxxxxxxxxx> wrote:
> On 1/14/22 10:44, Mariusz Tkaczyk wrote:
> > New events have been added in kernel 4.14 ("bind" and "unbind").
> > Systemd maintainer suggests to modify "add|change" branches.
> > This patches implements their suggestions. There is no issue yet
> > because new event types are not used in md.
> >
> > Please see systemd announcement for details[1].
> >
> > [1]
> > https://lists.freedesktop.org/archives/systemd-devel/2020-November/045646.html
> >
> > Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@xxxxxxxxxxxxxxx>
>
> Hi Mariusz,
>
> It looks fine to me, but it does raise the question how does this
> change affect anyone building mdadm running an older systemd since
> you're removing most of the add|change triggers in this patch?
>
Hi Jes,
Before 4.14 we had tree types of events:
add, change, remove
After 4.14 we have five types of events:
add, change, remove, bind, unbind
I just changed "add|change" to != "remove". Instead verifying positive
cases, I excluded the negative one. The result is the same. I can't see
any risk of regression here for older systemd.
Thanks,
Mariusz
