Re: [PATCH 1/3] raid0, linear, md: add error_handlers for raid0 and linear

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 12/17/21 10:00 AM, Guoqing Jiang wrote:
+static inline bool is_rdev_broken(struct md_rdev *rdev)
  {
-    if (!disk_live(rdev->bdev->bd_disk)) {
-        if (!test_and_set_bit(MD_BROKEN, &rdev->mddev->flags))
-            pr_warn("md: %s: %s array has a missing/failed member\n",
-                mdname(rdev->mddev), md_type);
-        return true;
-    }
-    return false;
+    return !disk_live(rdev->bdev->bd_disk);
  }


Besides, if MD_BROKEN is not set here then I think you can also delete the flag from other places as well.

Oops, I didn't notice the flag is set elsewhere.

Thanks,
Guoqing



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux