Re: [PATCH] mdadm/systemd: change KillMode from none to mixed in service files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi all,

On 01.12.21 17:23, Coly Li wrote:
On 12/2/21 12:08 AM, mtkaczyk wrote:
Hi Coly,

This patch changes KillMode in above listed service files from "none"
to "mixed", to follow systemd recommendation and avoid potential
unnecessary issue.
What about mdmonitor.service? Should we add it there too? Now it is not
defined.

It was overlooked when I did grep KillMode. Yes, I agree mdmonitor.service should have a KillMode key word as well.

Let me post a v2 version.

JFYI, when KillMode is not set, it defaults to KillMode=control-group, see https://www.freedesktop.org/software/systemd/man/systemd.kill.html.

Therefore, it shouldn't be necessary to explicitly add it (as long as control-group is working in case of mdmonitor.service, of course).

Best
Benjamin

Cc: Jes Sorensen <jsorensen@xxxxxx>
Not sure if it a problem but Jes uses: jes@xxxxxxxxxxxxxxxxxx for
communication with linux-raid.

Copied. Thanks for the hint.

Coly Li


--
Benjamin Brunner
Engineering Manager System Boot and Init
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5
90409 Nürnberg
Germany

HRB 36809, AG Nürnberg
Geschäftsführer: Ivo Totev





[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux