Re: [PATCH v4 2/4] ataflop: address add_disk() error handling on probe

To: Luis Chamberlain <mcgrof@xxxxxxxxxx>
Subject: Re: [PATCH v4 2/4] ataflop: address add_disk() error handling on probe
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 3 Nov 2021 19:21:09 +0100
Cc: axboe@xxxxxxxxx, hch@xxxxxx, penguin-kernel@xxxxxxxxxxxxxxxxxxx, dan.j.williams@xxxxxxxxx, vishal.l.verma@xxxxxxxxx, dave.jiang@xxxxxxxxx, ira.weiny@xxxxxxxxx, richard@xxxxxx, miquel.raynal@xxxxxxxxxxx, vigneshr@xxxxxx, efremov@xxxxxxxxx, song@xxxxxxxxxx, martin.petersen@xxxxxxxxxx, hare@xxxxxxx, jack@xxxxxxx, ming.lei@xxxxxxxxxx, tj@xxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20211103182016.GB7745@lst.de>
References: <20211103181258.1462704-1-mcgrof@kernel.org> <20211103181258.1462704-3-mcgrof@kernel.org> <20211103182016.GB7745@lst.de>
User-agent: Mutt/1.5.17 (2007-11-01)

Or maybe I should stop nitpicking for these cruft drivers.

I'm ok with this and the next patch:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH v4 0/4] last set for add_disk() error handling
  - From: Luis Chamberlain
- [PATCH v4 2/4] ataflop: address add_disk() error handling on probe
  - From: Luis Chamberlain
- Re: [PATCH v4 2/4] ataflop: address add_disk() error handling on probe
  - From: Christoph Hellwig