Re: [PATCH v2 07/13] nvdimm/pmem: use add_disk() error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Luis Chamberlain <mcgrof@xxxxxxxxxx>
Subject: Re: [PATCH v2 07/13] nvdimm/pmem: use add_disk() error handling
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 3 Nov 2021 17:06:51 +0100
Cc: axboe@xxxxxxxxx, hch@xxxxxx, penguin-kernel@xxxxxxxxxxxxxxxxxxx, dan.j.williams@xxxxxxxxx, vishal.l.verma@xxxxxxxxx, dave.jiang@xxxxxxxxx, ira.weiny@xxxxxxxxx, richard@xxxxxx, miquel.raynal@xxxxxxxxxxx, vigneshr@xxxxxx, efremov@xxxxxxxxx, song@xxxxxxxxxx, martin.petersen@xxxxxxxxxx, hare@xxxxxxx, jack@xxxxxxx, ming.lei@xxxxxxxxxx, tj@xxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20211103122157.1215783-8-mcgrof@kernel.org>
References: <20211103122157.1215783-1-mcgrof@kernel.org> <20211103122157.1215783-8-mcgrof@kernel.org>
User-agent: Mutt/1.5.17 (2007-11-01)

On Wed, Nov 03, 2021 at 05:21:51AM -0700, Luis Chamberlain wrote:
> Now that device_add_disk() supports returning an error, use
> that. We must unwind alloc_dax() on error.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH v2 00/13] block: add_disk() error handling stragglers
  - From: Luis Chamberlain
- [PATCH v2 07/13] nvdimm/pmem: use add_disk() error handling
  - From: Luis Chamberlain

Prev by Date: Re: [PATCH v2 06/13] nvdimm/pmem: cleanup the disk if pmem_release_disk() is yet assigned
Next by Date: Re: [PATCH v2 08/13] z2ram: add error handling support for add_disk()
Previous by thread: [PATCH v2 07/13] nvdimm/pmem: use add_disk() error handling
Next by thread: [PATCH v2 13/13] block: add __must_check for *add_disk*() callers
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID Wiki] [ATA RAID] [Linux SCSI Target Infrastructure] [Linux Block] [Linux IDE] [Linux SCSI] [Linux Hams] [Device Mapper] [Device Mapper Cryptographics] [Kernel] [Linux Admin] [Linux Net] [GFS] [RPM] [git] [Yosemite Forum]