Re: [PATCH 02/30] block: add a bdev_nr_bytes helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 02/30] block: add a bdev_nr_bytes helper
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Fri, 15 Oct 2021 14:35:15 +0100
Cc: Jens Axboe <axboe@xxxxxxxxx>, Coly Li <colyli@xxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>, Ryusuke Konishi <konishi.ryusuke@xxxxxxxxx>, Anton Altaparmakov <anton@xxxxxxxxxx>, Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Phillip Lougher <phillip@xxxxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, linux-nilfs@xxxxxxxxxxxxxxx, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, ntfs3@xxxxxxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx
In-reply-to: <20211015132643.1621913-3-hch@lst.de>
References: <20211015132643.1621913-1-hch@lst.de> <20211015132643.1621913-3-hch@lst.de>

On Fri, Oct 15, 2021 at 03:26:15PM +0200, Christoph Hellwig wrote:
> +static inline sector_t bdev_nr_bytes(struct block_device *bdev)
> +{
> +	return i_size_read(bdev->bd_inode);

Uh.  loff_t, surely?

Follow-Ups:
- Re: [PATCH 02/30] block: add a bdev_nr_bytes helper
  - From: Christoph Hellwig

References:
- don't use ->bd_inode to access the block device size v2
  - From: Christoph Hellwig
- [PATCH 02/30] block: add a bdev_nr_bytes helper
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 02/30] block: add a bdev_nr_bytes helper
Next by Date: Re: [PATCH 01/30] block: move the SECTOR_SIZE related definitions to blk_types.h
Previous by thread: [PATCH 02/30] block: add a bdev_nr_bytes helper
Next by thread: Re: [PATCH 02/30] block: add a bdev_nr_bytes helper
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID Wiki] [ATA RAID] [Linux SCSI Target Infrastructure] [Linux Block] [Linux IDE] [Linux SCSI] [Linux Hams] [Device Mapper] [Device Mapper Cryptographics] [Kernel] [Linux Admin] [Linux Net] [GFS] [RPM] [git] [Yosemite Forum]