Re: [PATCH 07/29] target/iblock: use bdev_nr_sectors instead of open coding it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
Subject: Re: [PATCH 07/29] target/iblock: use bdev_nr_sectors instead of open coding it
From: Chaitanya Kulkarni <chaitanyak@xxxxxxxxxx>
Date: Wed, 13 Oct 2021 22:37:47 +0000
Accept-language: en-US
Cc: Coly Li <colyli@xxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>, Ryusuke Konishi <konishi.ryusuke@xxxxxxxxx>, Anton Altaparmakov <anton@xxxxxxxxxx>, Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Phillip Lougher <phillip@xxxxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "dm-devel@xxxxxxxxxx" <dm-devel@xxxxxxxxxx>, "drbd-dev@xxxxxxxxxxxxxxxx" <drbd-dev@xxxxxxxxxxxxxxxx>, "linux-bcache@xxxxxxxxxxxxxxx" <linux-bcache@xxxxxxxxxxxxxxx>, "linux-raid@xxxxxxxxxxxxxxx" <linux-raid@xxxxxxxxxxxxxxx>, "linux-mtd@xxxxxxxxxxxxxxxxxxx" <linux-mtd@xxxxxxxxxxxxxxxxxxx>, "linux-nvme@xxxxxxxxxxxxxxxxxxx" <linux-nvme@xxxxxxxxxxxxxxxxxxx>, "linux-scsi@xxxxxxxxxxxxxxx" <linux-scsi@xxxxxxxxxxxxxxx>, "target-devel@xxxxxxxxxxxxxxx" <target-devel@xxxxxxxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, "linux-btrfs@xxxxxxxxxxxxxxx" <linux-btrfs@xxxxxxxxxxxxxxx>, "linux-ext4@xxxxxxxxxxxxxxx" <linux-ext4@xxxxxxxxxxxxxxx>, "jfs-discussion@xxxxxxxxxxxxxxxxxxxxx" <jfs-discussion@xxxxxxxxxxxxxxxxxxxxx>, "linux-nfs@xxxxxxxxxxxxxxx" <linux-nfs@xxxxxxxxxxxxxxx>, "linux-nilfs@xxxxxxxxxxxxxxx" <linux-nilfs@xxxxxxxxxxxxxxx>, "linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx" <linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx>, "ntfs3@xxxxxxxxxxxxxxx" <ntfs3@xxxxxxxxxxxxxxx>, "reiserfs-devel@xxxxxxxxxxxxxxx" <reiserfs-devel@xxxxxxxxxxxxxxx>
In-reply-to: <20211013051042.1065752-8-hch@lst.de>
References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-8-hch@lst.de>
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

On 10/12/2021 10:10 PM, Christoph Hellwig wrote:
> Use the proper helper to read the block device size.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---

Bodo's comment is good for the code reliability.

Either way, looks good.

Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>

References:
- don't use ->bd_inode to access the block device size
  - From: Christoph Hellwig
- [PATCH 07/29] target/iblock: use bdev_nr_sectors instead of open coding it
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 11/29] btrfs: use bdev_nr_sectors instead of open coding it
Next by Date: Re: [PATCH 11/29] btrfs: use bdev_nr_sectors instead of open coding it
Previous by thread: Re: [PATCH 07/29] target/iblock: use bdev_nr_sectors instead of open coding it
Next by thread: [PATCH 08/29] fs: use bdev_nr_sectors instead of open coding it in blkdev_max_block
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID Wiki] [ATA RAID] [Linux SCSI Target Infrastructure] [Linux Block] [Linux IDE] [Linux SCSI] [Linux Hams] [Device Mapper] [Device Mapper Cryptographics] [Kernel] [Linux Admin] [Linux Net] [GFS] [RPM] [git] [Yosemite Forum]