On 10/7/21 2:20 PM, Song Liu wrote:
On Mon, Oct 4, 2021 at 8:40 AM Guoqing Jiang <guoqing.jiang@xxxxxxxxx> wrote:Add the paramenter since the err retry logic is only meaningful when the caller is handle_read_error. Signed-off-by: Guoqing Jiang <guoqing.jiang@xxxxxxxxx> --- drivers/md/raid10.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index aa2636582841..29eb538db953 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -1116,7 +1116,7 @@ static void regular_request_wait(struct mddev *mddev, struct r10conf *conf, } static void raid10_read_request(struct mddev *mddev, struct bio *bio, - struct r10bio *r10_bio) + struct r10bio *r10_bio, bool read_err) { struct r10conf *conf = mddev->private; struct bio *read_bio; @@ -1129,7 +1129,7 @@ static void raid10_read_request(struct mddev *mddev, struct bio *bio, struct md_rdev *err_rdev = NULL; gfp_t gfp = GFP_NOIO; - if (slot >= 0 && r10_bio->devs[slot].rdev) { + if (read_err && slot >= 0 && r10_bio->devs[slot].rdev) {How about we just move this section to a separate function?
Will add an additional patch for it. Thanks, Guoqing
