Hi Hannes Thanks for these patches. It's a good idea to make codes more clearly that which codes belong to which file. There are many efforts that move codes from mdadm.c and mdadm.h to specific files. Is it better to put these patches together? For example, the patches(6, 11, 12, 16, 19, 20, 27, 28) try to clean mdadm.c. Could you put similar patches together? And there are some rename patches too, they are sporadic. For patch03, the argument is name, but it uses optarg in the function mdadm_get_layout. Is it an error? By the way, are there some other users who use the library besides mdadm/mdmon? And it's good for me if you send patches directly by email to linux-raid mail list. Best Regards Xiao On Wed, Aug 25, 2021 at 10:35 PM Hannes Reinecke <hare@xxxxxxx> wrote: > > Hi all, > > this is, contrary to the subject, not a patch, but rather a question on > how to submit a patchset. > I've been working on splitting off a shared library from mdadm, with the > aim that it can be included from other programs. > Reasoning behind it that I've written a monitor program > (github.com:/hreinecke/md_monitor) and found it a major pain having to > exec() mdadm, and then keep fingers crossed that things succeed; error > recovery from _that_ turned out to be a major drag. And so I figured > that a shared library is possibly the best way to go. > > (And, as a side note: having a shared library would also allow to build > a python binding, which possibly will have even more use-cases ...) > > So I've build a patchset to split off a shared library from mdadm, and > build mdadm against that: > > git://git.kernel.org/pub/scm/linux/kernel/git/hare/mdadm.git > branch shlib > > But as it turns out, these are 30+ patches, and I didn't want to flood > the mailinglist with that. > So what are the procedures here? > > Are you okay with having the entire patchset on the mailing list? > Or are there other ways? > > Thanks for your help. > > Cheers, > > Hannes > -- > Dr. Hannes Reinecke Kernel Storage Architect > hare@xxxxxxx +49 911 74053 688 > SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg > HRB 36809 (AG Nürnberg), GF: Felix Imendörffer >
