Re: [PATCH V3] raid1: ensure write behind bio has less than BIO_MAX_VECS sectors

Guoqing Jiang <guoqing.jiang@xxxxxxxxx> · Tue, 24 Aug 2021 08:43:18 +0800

Hi,

Thanks for the report!

On 8/23/21 8:19 PM, kernel test robot wrote:
Hi Guoqing,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on song-md/md-next]
[also build test ERROR on v5.14-rc7 next-20210820]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Guoqing-Jiang/raid1-ensure-write-behind-bio-has-less-than-BIO_MAX_VECS-sectors/20210823-154653
base:   git://git.kernel.org/pub/scm/linux/kernel/git/song/md.git md-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
         chmod +x ~/bin/make.cross
         # https://github.com/0day-ci/linux/commit/302a06a55fac4a9fb10f57dc96f6a618f3e853b4
         git remote add linux-review https://github.com/0day-ci/linux
         git fetch --no-tags linux-review Guoqing-Jiang/raid1-ensure-write-behind-bio-has-less-than-BIO_MAX_VECS-sectors/20210823-154653
         git checkout 302a06a55fac4a9fb10f57dc96f6a618f3e853b4
         # save the attached .config to linux build tree
         mkdir build_dir
         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/md/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

    drivers/md/raid1.c: In function 'raid1_write_request':
drivers/md/raid1.c:1393:44: error: 'mirror' undeclared (first use in this function); did you mean 'md_error'?
     1393 |                 if (test_bit(WriteMostly, &mirror->rdev->flags))
          |                                            ^~~~~~
          |                                            md_error

Oops, will fix it.

drivers/md/raid1.c:1477:52: error: 'PAGE_SECTORS' undeclared (first use in this function)
     1477 |                                     BIO_MAX_VECS * PAGE_SECTORS);
          |                                                    ^~~~~~~~~~~~

This patch is supposed to be merged by block tree due to dependency.

Thanks,
Guoqing