Re: [Update PATCH V3 2/8] md: add io accounting for raid0 and raid5

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 2, 2021 at 6:17 PM Guoqing Jiang <jgq516@xxxxxxxxx> wrote:
>
>
>
> On 6/1/21 9:19 AM, Guoqing Jiang wrote:
> > From: Guoqing Jiang <jgq516@xxxxxxxxx>
> >
> > We introduce a new bioset (io_acct_set) for raid0 and raid5 since they
> > don't own clone infrastructure to accounting io. And the bioset is added
> > to mddev instead of to raid0 and raid5 layer, because with this way, we
> > can put common functions to md.h and reuse them in raid0 and raid5.
> >
> > Also struct md_io_acct is added accordingly which includes io start_time,
> > the origin bio and cloned bio. Then we can call bio_{start,end}_io_acct
> > to get related io status.
> >
> > Signed-off-by: Guoqing Jiang <jiangguoqing@xxxxxxxxxx>
> > Signed-off-by: Song Liu <song@xxxxxxxxxx>
> > ---
> > Hi Song,
> >
> > Please consider apply the updated patch which has minor changes based on
> > Christoph's comment.
> >
> > 1. don't create io_acct_set for raid1 and raid10.
> > 2. update comment for md_account_bio.
>
> Pls ignore this given it didn't check all the places before io_acct_set.
> Do you want an incremental patch against for-next branch or a fresh
> one to replace current patch in the tree?

Hi Guoqing,

Thanks for the hard work on this. Please send a fix patch on top of current
md-next.

Song



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux