On 5/10/21 9:46 AM, Guoqing Jiang wrote: > On 5/10/21 2:00 PM, Christoph Hellwig wrote: >> On Sat, May 08, 2021 at 11:48:15AM +0800, Guoqing Jiang wrote: >>> It looks like stack overflow happened for split bio, to fix this, >>> let's keep split bio untouched in md_submit_bio. >>> >>> As a side effect, we need to export bio_chain_endio. >> Err, no. The right answer is to not change ->bi_end_io of bios that >> you do not own instead of using a horrible hack to skip accounting for >> bios that have no more or less reason to be accounted than others bios. > > Thanks for the reply. I suppose that md needs to revert current > implementation of accounting io stats, then re-implement it. > > Song and Artur, what are your opinion? In the initial version of the io accounting patch the bio was cloned instead of just overriding bi_end_io and bi_private. Would this be the right approach? https://lore.kernel.org/linux-raid/20200601161256.27718-1-artur.paszkiewicz@xxxxxxxxx/
