Re: [PATCH 05/24] block: remove the update_bdev parameter from set_capacity_revalidate_and_notify

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 05/24] block: remove the update_bdev parameter from set_capacity_revalidate_and_notify
From: Petr Vorel <pvorel@xxxxxxx>
Date: Thu, 12 Nov 2020 20:22:23 +0100
Cc: Jens Axboe <axboe@xxxxxxxxx>, Justin Sanders <justin@xxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Ilya Dryomov <idryomov@xxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Stefan Hajnoczi <stefanha@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Minchan Kim <minchan@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, dm-devel@xxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <20201111082658.3401686-6-hch@lst.de>
References: <20201111082658.3401686-1-hch@lst.de> <20201111082658.3401686-6-hch@lst.de>
Reply-to: Petr Vorel <pvorel@xxxxxxx>

Hi Christoph,

> The update_bdev argument is always set to true, so remove it.  Also
> rename the function to the slighly less verbose set_capacity_and_notify,
> as propagating the disk size to the block device isn't really
> revalidation.

> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Reviewed-by: Petr Vorel <pvorel@xxxxxxx>

Nice cleanup.

Kind regards,
Petr

References:
- cleanup updating the size of block devices v2
  - From: Christoph Hellwig
- [PATCH 05/24] block: remove the update_bdev parameter from set_capacity_revalidate_and_notify
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH v2] md/cluster: fix deadlock when doing reshape job
Next by Date: Re: [PATCH v2] md/cluster: fix deadlock when doing reshape job
Previous by thread: Re: [PATCH 05/24] block: remove the update_bdev parameter from set_capacity_revalidate_and_notify
Next by thread: [PATCH 06/24] block: add a return value to set_capacity_and_notify
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID Wiki] [ATA RAID] [Linux SCSI Target Infrastructure] [Linux Block] [Linux IDE] [Linux SCSI] [Linux Hams] [Device Mapper] [Device Mapper Cryptographics] [Kernel] [Linux Admin] [Linux Net] [GFS] [RPM] [git] [Yosemite Forum]