Re: [PATCH v2] md/cluster: block reshape requests with resync job initiated from remote node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Song & Guoqing,

Thank you for your kindly review.
I feel it's unclear and mess up to put patch 1 & 2 together.
So I split them and first send patch 1 for review.

I am not sure whether I should add "reviewd-by Song & Guoqing" in comments.
Because the code is correct, comments need to revise.

btw,
For patch 2, I need some time to answer Guoqing's question. please wait.

Thanks.

On 11/10/20 11:50 PM, Zhao Heming wrote:
> In cluster env, a node can start resync job when the resync cmd was
> executed on a different node. Reshape requests should be blocked for
> resync job initiated by any node. Current code only checks local resync
> condition to block reshape requests. This results in a chaos result when
> resync was doing on different node.
> 
> Fix this by adding the extra check MD_RESYNCING_REMOTE.
> 
> ... ...
>
> Signed-off-by: Zhao Heming <heming.zhao@xxxxxxxx>
> ---
> v2:
> - for clearly, split patch-v1 into two single patch to review.
> - revise patch subject & comments.
> - add test result in comments.
> 
> v1:
> - add cover-letter
> - add more descriptions in commit log
> 
> v0:
> - create 2 patches, patch 1/2 is this patch.
> 
> ---
>   drivers/md/md.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 




[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux