On Thu, Nov 5, 2020 at 5:11 AM Zhao Heming <heming.zhao@xxxxxxxx> wrote: > > Test script (reproducible steps): > ``` > ssh root@node2 "mdadm -S --scan" > mdadm -S --scan > mdadm --zero-superblock /dev/sd{g,h,i} > for i in {g,h,i};do dd if=/dev/zero of=/dev/sd$i oflag=direct bs=1M \ > count=20; done > > echo "mdadm create array" > mdadm -C /dev/md0 -b clustered -e 1.2 -n 2 -l mirror /dev/sdg /dev/sdh > echo "set up array on node2" > ssh root@node2 "mdadm -A /dev/md0 /dev/sdg /dev/sdh" > > sleep 5 > > mdadm --manage --add /dev/md0 /dev/sdi > mdadm --wait /dev/md0 > mdadm --grow --raid-devices=3 /dev/md0 > > mdadm /dev/md0 --fail /dev/sdg > mdadm /dev/md0 --remove /dev/sdg > #mdadm --wait /dev/md0 > mdadm --grow --raid-devices=2 /dev/md0 > ``` I found it was hard for me to follow this set. IIUC, the two patches try to address one issue. Please add a cover letter and reorganize the descriptions like: cover-letter: error behavior, repro steps, analysis, and maybe describe the relationship of the two patches. 1/2 and 2/2: what is being fixed. Thanks, Song [...]