On 9/15/20 3:44 AM, Xiao Ni wrote:
> Journal disk and bitmap can't exist at the same time. It needs to check if the raid
> has a journal disk when creating bitmap.
>
> Signed-off-by: Xiao Ni <xni@xxxxxxxxxx>
> ---
> Create.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Create.c b/Create.c
> index 6f84e5b..0efa19c 100644
> --- a/Create.c
> +++ b/Create.c
> @@ -542,6 +542,7 @@ int Create(struct supertype *st, char *mddev,
> if (!s->bitmap_file &&
> s->level >= 1 &&
> st->ss->add_internal_bitmap &&
> + s->journaldisks == 0 &&
> (s->consistency_policy != CONSISTENCY_POLICY_RESYNC &&
> s->consistency_policy != CONSISTENCY_POLICY_PPL) &&
> (s->write_behind || s->size > 100*1024*1024ULL)) {
>
Applied!
That said, I'd love if we could do something to get rid of some of these
very excessive if statements. It is extremely difficult to verify all
cases are correct.
Thanks,
Jes
