On Tue, Jul 28, 2020 at 6:15 PM Xiao Ni <xni@xxxxxxxxxx> wrote: > > > > On 07/29/2020 08:43 AM, Song Liu wrote: > >> Hi Song > >> > >> This calculation of bitmap is decided by mdadm. In mdadm super1.c > >> choose_bm_space function, > >> it uses this way to calculate bitmap space. Do I need to add comments > >> here to describe this? > >> Something like "mdadm function choose_bm_space decides the bitmap space"? > > Thanks for the explanation. > > > > I merged the two patches, made some changes, and applied it to md-next. Please > > let me know whether it looks good. > > > The function super_10_choose_bm_space can make people confused. All > types of super1 calculate > bitmap space in the same way (super1.0, 1.1 and 1.2). Could you change > the function name to > super_1_choose_bm_space? Updated. Thanks! Song
