On 7/28/20 9:41 AM, Jens Axboe wrote:
> On 7/24/20 1:32 AM, Christoph Hellwig wrote:
>> Hi Jens,
>>
>> this series contains a bunch of different BDI cleanups. The biggest item
>> is to isolate block drivers from the BDI in preparation of changing the
>> lifetime of the block device BDI in a follow up series.
>
> Applied, thanks.
Dropped:
CC block/blk-sysfs.o
block/blk-sysfs.c:608:16: error: ‘blk_throtl_sample_show’ undeclared here (not in a function); did you mean ‘blk_throtl_sample_entry’?
608 | QUEUE_RW_ENTRY(blk_throtl_sample, "throttle_sample_time");
| ^~~~~~~~~~~~~~~~~
block/blk-sysfs.c:563:10: note: in definition of macro ‘QUEUE_RW_ENTRY’
563 | .show = _prefix##_show, \
| ^~~~~~~
block/blk-sysfs.c:608:16: error: ‘blk_throtl_sample_store’ undeclared here (not in a function); did you mean ‘blk_throtl_sample_entry’?
608 | QUEUE_RW_ENTRY(blk_throtl_sample, "throttle_sample_time");
| ^~~~~~~~~~~~~~~~~
block/blk-sysfs.c:564:11: note: in definition of macro ‘QUEUE_RW_ENTRY’
564 | .store = _prefix##_store, \
| ^~~~~~~
block/blk-sysfs.c:657:3: error: ‘blk_throtl_sample_time_entry’ undeclared here (not in a function); did you mean ‘blk_throtl_sample_time_store’?
657 | &blk_throtl_sample_time_entry.attr,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| blk_throtl_sample_time_store
block/blk-sysfs.c:608:16: warning: ‘blk_throtl_sample_entry’ defined but not used [-Wunused-variable]
608 | QUEUE_RW_ENTRY(blk_throtl_sample, "throttle_sample_time");
| ^~~~~~~~~~~~~~~~~
block/blk-sysfs.c:561:33: note: in definition of macro ‘QUEUE_RW_ENTRY’
561 | static struct queue_sysfs_entry _prefix##_entry = { \
| ^~~~~~~
make[1]: *** [scripts/Makefile.build:281: block/blk-sysfs.o] Error 1
make: *** [Makefile:1756: block] Error 2
from "block: add helper macros for queue sysfs entries"
This has not seen a full compile test even...
--
Jens Axboe
