On 22/07/20 08:20, heming.zhao@xxxxxxxx wrote: > During I was creating patch, I found the ExamineBitmap() has memory leak issue. > I am not sure whether the leak issue should be fixed. > (Because when mdadm cmd finish, all leaked memory will be released). > The IsBitmapDirty() used some of ExamineBitmap() code, and I only fixed leaked issue in IsBitmapDirty(). > My gut feel? Firstly, "do things right" - it should be fixed. Second - are you sure this code is not run while mdadm is running as a daemon? It's all very well saying it will be released, but but mdadm could be running for a looonnngg time. Cheers, Wol
