>>>>> "Artur" == Artur Paszkiewicz <artur.paszkiewicz@xxxxxxxxx> writes: Artur> On 6/2/20 8:48 AM, Song Liu wrote: >>> + clone = bio_clone_fast(bio, GFP_NOIO, &mddev->md_io_bs); >> >> Handle clone == NULL? Artur> I think this should never fail - bio_alloc_bioset() guarantees that. It Artur> is used in a similar manner in raid1 and raid10. How about Artur> BUG_ON(clone == NULL)? No, use WARN_ON() instead, why would you bug the entire system for just one logical device throwing an error?