Re: [PATCH v3 01/11] md/raid5: add CONFIG_MD_RAID456_STRIPE_SHIFT to set STRIPE_SIZE

Yufen Yu <yuyufen@xxxxxxxxxx> · Fri, 29 May 2020 16:42:58 +0800

On 2020/5/28 22:23, Song Liu wrote:
On Wed, May 27, 2020 at 6:20 AM Yufen Yu <yuyufen@xxxxxxxxxx> wrote:

[...]

diff --git a/drivers/md/raid5.h b/drivers/md/raid5.h
index f90e0704bed9..b25f107dafc7 100644
--- a/drivers/md/raid5.h
+++ b/drivers/md/raid5.h
@@ -472,7 +472,9 @@ struct disk_info {
   */

  #define NR_STRIPES             256
-#define STRIPE_SIZE            PAGE_SIZE
+#define CONFIG_STRIPE_SIZE     (CONFIG_MD_RAID456_STRIPE_SHIFT << 9)
+#define STRIPE_SIZE            \
+       (CONFIG_STRIPE_SIZE > PAGE_SIZE ? PAGE_SIZE : CONFIG_STRIPE_SIZE)
  #define STRIPE_SHIFT           (PAGE_SHIFT - 9)

I think we also need to update STRIPE_SHIFT.

Yeah, I forgot to update it. Thanks for catching this.

Thanks,
Yufen






