On 5/27/20 3:14 AM, Kinga Tanska wrote:
> Manual assembly with existing link caused overwriting
> this link. Add checking link and block this situation.
>
> Change-Id: I29ef58636e8fd8583bcaef1b28b6cf2edec385ef
> Signed-off-by: Kinga Tanska <kinga.tanska@xxxxxxxxx>
> ---
> Assemble.c | 4 ++++
> 1 file changed, 4 insertions(+)
Looks fine to me, but what is that non-standard Change-Id: tag you added?
Thanks,
Jes
> diff --git a/Assemble.c b/Assemble.c
> index 6b5a7c8e..92616251 100644
> --- a/Assemble.c
> +++ b/Assemble.c
> @@ -1482,6 +1482,10 @@ try_again:
> name = content->name;
> break;
> }
> + if (mddev && map_by_name(&map, mddev) != NULL) {
> + pr_err("Cannot create device with %s because is in use\n", mddev);
> + goto out;
> + }
> if (!auto_assem)
> /* If the array is listed in mdadm.conf or on
> * command line, then we trust the name
>
