On Tue, Apr 21, 2020 at 5:40 AM Yufen Yu <yuyufen@xxxxxxxxxx> wrote:
>
[...]
> Signed-off-by: Yufen Yu <yuyufen@xxxxxxxxxx>
> ---
> +
> +/*
> + * We want to 'compress' multiple buffers to one real page for
> + * stripe_head when PAGE_SIZE is biggger than STRIPE_SIZE. If their
> + * values are equal, no need to use this strategy. For now, it just
> + * support raid level less than 5.
> + */
I don't think "compress" is the right terminology here. It is more
like "share" a page.
Why not support raid6 here?
Overall, the set looks reasonable to me. Please revise and send another version.
Thanks,
Song
> +static inline int raid5_compress_stripe_pages(struct r5conf *conf)
> +{
> + return (PAGE_SIZE > STRIPE_SIZE) && (conf->level < 6);
> +}
> +
> extern void md_raid5_kick_device(struct r5conf *conf);
> extern int raid5_set_cache_size(struct mddev *mddev, int size);
> extern sector_t raid5_compute_blocknr(struct stripe_head *sh, int i, int previous);
> --
> 2.21.1
>
