On 4/16/19 12:08 PM, Gioh Kim wrote: > When mdadm tries to assemble one working device and one zeroed-out device, > it failed but print successful message because there is --uuid option. > > Following script always reproduce it. > > dd if=/dev/zero of=/dev/ram0 oflag=direct > dd if=/dev/zero of=/dev/ram1 oflag=direct > ./mdadm -C /dev/md111 -e 1.2 --uuid="12345678:12345678:12345678:12345678" \ > -l1 -n2 /dev/ram0 /dev/ram1 > ./mdadm -S /dev/md111 > dd if=/dev/zero of=/dev/ram1 oflag=direct > ./mdadm -A /dev/md111 --uuid="12345678:12345678:12345678:12345678" \ > /dev/ram0 /dev/ram1 > > Following is message from mdadm. > > mdadm: No super block found on /dev/ram1 (Expected magic a92b4efc, got 00000000) > mdadm: no RAID superblock on /dev/ram1 > mdadm: /dev/md111 assembled from 1 drive - need all 2 to start it (use --run to insist). > > The mdadm say that it assembled but mdadm does not create /dev/md111. > The message is wrong. > > After applying this patch, mdadm reports error correctly as following. > > mdadm: No super block found on /dev/ram1 (Expected magic a92b4efc, got 00000000) > mdadm: no RAID superblock on /dev/ram1 > mdadm: /dev/ram1 has no superblock - assembly aborted > > Signed-off-by: Gioh Kim <gi-oh.kim@xxxxxxxxxxxxxxx> Applied! This looks like an ideal case for something to be added to the test suite. Thanks, Jes
