On 2020/4/9 7:52 下午, colyli@xxxxxxx wrote:
> From: Coly Li <colyli@xxxxxxx>
>
> In mddev_create_serial_pool(), memalloc scope APIs memalloc_noio_save()
> and memalloc_noio_restore() are used when allocating memory by calling
> mempool_create_kmalloc_pool(). After adding the memalloc scope APIs in
> raid array suspend context, it is unncessary to explicitly call them
> around mempool_create_kmalloc_pool() any longer.
>
> This patch removes the redundant memalloc scope APIs in
> mddev_create_serial_pool().
>
> Signed-off-by: Coly Li <colyli@xxxxxxx>
> Cc: Guoqing Jiang <guoqing.jiang@xxxxxxxxxxxxxxx>
> ---
> drivers/md/md.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 1a8e1bb3a7f4..ef29f49a0f51 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -229,11 +229,9 @@ void mddev_create_serial_pool(struct mddev *mddev, struct md_rdev *rdev,
> if (mddev->serial_info_pool == NULL) {
> unsigned int noio_flag;
^^^^^^^^^^^^^^^^^^^^^^^ I will remove this one in v3 series.
Coly Li
>
> - noio_flag = memalloc_noio_save();
> mddev->serial_info_pool =
> mempool_create_kmalloc_pool(NR_SERIAL_INFOS,
> sizeof(struct serial_info));
> - memalloc_noio_restore(noio_flag);
> if (!mddev->serial_info_pool) {
> rdevs_uninit_serial(mddev);
> pr_err("can't alloc memory pool for serialization\n");
>
