Re: [PATCH] raid5: need to set STRIPE_HANDLE for batch head

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for the fix!

On Wed, Nov 27, 2019 at 8:58 AM <jgq516@xxxxxxxxx> wrote:
>
> From: Guoqing Jiang <guoqing.jiang@xxxxxxxxxxxxxxx>
>
> With commit 6ce220dd2f8ea71d6afc29b9a7524c12e39f374a ("raid5: don't set

In the future, please keep only 12 bytes of the commit hash. I will
fix it this time.

> STRIPE_HANDLE to stripe which is in batch list"), we don't want to set
> STRIPE_HANDLE flag for sh which is already in batch list.
>
> However, the stripe which is the head of batch list should set this flag,
> otherwise panic could happen inside init_stripe at BUG_ON(sh->batch_head),
> it is reproducible with raid5 on top of nvdimm devices per Xiao oberserved.
>
> Thanks for Xiao's effort to verify the change.

Xiao, please reply with your "Tested-by".

Thanks,
Song



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux