On 11/9/19 12:20 AM, Song Liu wrote:
On Wed, Nov 6, 2019 at 2:43 AM Guoqing Jiang
<guoqing.jiang@xxxxxxxxxxxxxxx> wrote:
On 11/5/19 11:03 PM, Song Liu wrote:
On Fri, Nov 1, 2019 at 7:23 AM <jgq516@xxxxxxxxx> wrote:
From: Guoqing Jiang <guoqing.jiang@xxxxxxxxxxxxxxx>
Obviously, IO serialization could cause the degradation of
performance. In order to reduce the degradation, it is better
to replace link list with rb tree.
And with the inspiration of drbd_interval.c, a simpler
Can we reuse the logic in drdb_interval.c instead of duplicating it?
Yes, I thought about it, but we need to move the logic from drbd to
a common place before we can reuse it. And seems pat_rbtree.c
has the similar implementation, so we can reduce a lot duplication.
But it definitely needs more efforts to put the logic to a common place
since it involves different subsystems, which means we have to wait it
for a longer time. Or we just add the logic here, then try to refactor the
common code later.
I would prefer we at least try the move. If we got push back from drbd
maintainers, we can go back to current approach.
Ok, I will give it a try.
Thanks,
Guoqing
