Hi Nigel, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.4-rc6 next-20191105] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Nigel-Croxon/raid456-avoid-second-retry-of-read-error/20191105-040741 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a99d8080aaf358d5d23581244e5da23b35e340b9 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=arm If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers//md/md.c: In function 'set_raid456_retry_re': >> drivers//md/md.c:131:8: error: 'set_bit' undeclared (first use in this function); did you mean '_set_bit'? (re ? set_bit : clear_bit)(MD_RAID456_RETRY_RE, &mddev->flags); ^~~~~~~ _set_bit drivers//md/md.c:131:8: note: each undeclared identifier is reported only once for each function it appears in >> drivers//md/md.c:131:18: error: 'clear_bit' undeclared (first use in this function); did you mean '_clear_bit'? (re ? set_bit : clear_bit)(MD_RAID456_RETRY_RE, &mddev->flags); ^~~~~~~~~ _clear_bit vim +131 drivers//md/md.c 127 128 static int sysctl_raid456_retry_read_error = 0; 129 static inline void set_raid456_retry_re(struct mddev *mddev, int re) 130 { > 131 (re ? set_bit : clear_bit)(MD_RAID456_RETRY_RE, &mddev->flags); 132 } 133 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip