On Wed, Oct 2, 2019 at 1:02 AM Song Liu <liu.song.a23@xxxxxxxxx> wrote: > > On Thu, Sep 26, 2019 at 4:55 AM <jgq516@xxxxxxxxx> wrote: > > > > From: Guoqing Jiang <guoqing.jiang@xxxxxxxxxxxxxxx> > > > > We need to move "spin_lock_irq(&bitmap->counts.lock)" before unmap the previous > > storage, otherwise panic like belows could happen as follows. > > > > [ 902.353802] sdl: detected capacity change from 1077936128 to 3221225472 > > [ 902.616948] general protection fault: 0000 [#1] SMP > > [snip] > > [ 902.618588] CPU: 12 PID: 33698 Comm: md0_raid1 Tainted: G O 4.14.144-1-pserver #4.14.144-1.1~deb10 > > [ 902.618870] Hardware name: Supermicro SBA-7142G-T4/BHQGE, BIOS 3.00 10/24/2012 > > [ 902.619120] task: ffff9ae1860fc600 task.stack: ffffb52e4c704000 > > [ 902.619301] RIP: 0010:bitmap_file_clear_bit+0x90/0xd0 [md_mod] > > [ 902.619464] RSP: 0018:ffffb52e4c707d28 EFLAGS: 00010087 > > [ 902.619626] RAX: ffe8008b0d061000 RBX: ffff9ad078c87300 RCX: 0000000000000000 > > [ 902.619792] RDX: ffff9ad986341868 RSI: 0000000000000803 RDI: ffff9ad078c87300 > > [ 902.619986] RBP: ffff9ad0ed7a8000 R08: 0000000000000000 R09: 0000000000000000 > > [ 902.620154] R10: ffffb52e4c707ec0 R11: ffff9ad987d1ed44 R12: ffff9ad0ed7a8360 > > [ 902.620320] R13: 0000000000000003 R14: 0000000000060000 R15: 0000000000000800 > > [ 902.620487] FS: 0000000000000000(0000) GS:ffff9ad987d00000(0000) knlGS:0000000000000000 > > [ 902.620738] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > [ 902.620901] CR2: 000055ff12aecec0 CR3: 0000001005207000 CR4: 00000000000406e0 > > [ 902.621068] Call Trace: > > [ 902.621256] bitmap_daemon_work+0x2dd/0x360 [md_mod] > > [ 902.621429] ? find_pers+0x70/0x70 [md_mod] > > [ 902.621597] md_check_recovery+0x51/0x540 [md_mod] > > [ 902.621762] raid1d+0x5c/0xeb0 [raid1] > > [ 902.621939] ? try_to_del_timer_sync+0x4d/0x80 > > [ 902.622102] ? del_timer_sync+0x35/0x40 > > [ 902.622265] ? schedule_timeout+0x177/0x360 > > [ 902.622453] ? call_timer_fn+0x130/0x130 > > [ 902.622623] ? find_pers+0x70/0x70 [md_mod] > > [ 902.622794] ? md_thread+0x94/0x150 [md_mod] > > [ 902.622959] md_thread+0x94/0x150 [md_mod] > > [ 902.623121] ? wait_woken+0x80/0x80 > > [ 902.623280] kthread+0x119/0x130 > > [ 902.623437] ? kthread_create_on_node+0x60/0x60 > > [ 902.623600] ret_from_fork+0x22/0x40 > > [ 902.624225] RIP: bitmap_file_clear_bit+0x90/0xd0 [md_mod] RSP: ffffb52e4c707d28 > > > > Because mdadm was running on another cpu to do resize, so bitmap_resize was > > called to replace bitmap as below shows. > > > > PID: 38801 TASK: ffff9ad074a90e00 CPU: 0 COMMAND: "mdadm" > > [exception RIP: queued_spin_lock_slowpath+56] > > [snip] > > --- <NMI exception stack> --- > > nit: this --- above will trim the rest of the commit log. So I > updated it before applying. > > Also, checkpatch.pl complains > > WARNING: Possible unwrapped commit description (prefer a maximum 75 > chars per line) > > for multiple lines. I fixed them before applying. > > In the future, please check the patch before sending. > > Thanks, > Song I noticed this when applying to our tree, we will be more careful. Guoqing is on vacation, so I'm replying. Thanks, Jinpu
