On 8/16/19 5:06 AM, Krzysztof Smolinski wrote: > GCC 8 checks possible truncation during snprintf more strictly > than GCC 7 which result in compilation errors. To fix this > problem checking result of snprintf against errors has been added. > > Signed-off-by: Krzysztof Smolinski <krzysztof.smolinski@xxxxxxxxx> > --- > sysfs.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) Applied thanks! Note my ubi key fried itself so I need to setup a new one before I can push to kernel.org. I am glad to see some of this addressed, but the problem is much bigger. We need to fixup super-intel.c to build with gcc 9, not just gcc 8. I did a bunch of stuff, but the bigger problems remain. I am not a huge fan of just hiding it via typecasts, I'd like to see a proper solution. Cheers, Jes