Re: [PATCH] mdadm.h: include sysmacros.h unconditionally

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/6/19 3:05 PM, Baruch Siach wrote:
> musl libc now also requires sys/sysmacros.h for the major/minor macros.
> All supported libc implementations carry sys/sysmacros.h, including
> diet-libc, klibc, and uclibc-ng.
> 
> Cc: Hauke Mehrtens <hauke@xxxxxxxxxx>
> Signed-off-by: Baruch Siach <baruch@xxxxxxxxxx>

Acked-by: Hauke Mehrtens <hauke@xxxxxxxxxx>

I was not aware of this compile switch and it looks better than my patch.

> ---
>  mdadm.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/mdadm.h b/mdadm.h
> index c36d7fdb10f6..d61a9ca82dc1 100644
> --- a/mdadm.h
> +++ b/mdadm.h
> @@ -45,10 +45,8 @@ extern __off64_t lseek64 __P ((int __fd, __off64_t __offset, int __whence));
>  #include	<errno.h>
>  #include	<string.h>
>  #include	<syslog.h>
> -#ifdef __GLIBC__
>  /* Newer glibc requires sys/sysmacros.h directly for makedev() */
>  #include	<sys/sysmacros.h>
> -#endif
>  #ifdef __dietlibc__
>  #include	<strings.h>
>  /* dietlibc has deprecated random and srandom!! */
> 




[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux