Re: [PATCH v1] md: Convert to use int_pow()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On Jul 26, 2019, at 9:48 AM, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> 
> On Tue, Jul 23, 2019 at 11:41:55PM +0300, Andy Shevchenko wrote:
>> Instead of linear approach to calculate power of 10, use generic int_pow()
>> which does it better.
> 
> I took into Cc drivers/dm guys as they might have known something about md raid
> state of affairs. Sorry if I mistakenly added somebody.
> 
> Who is doing this?
> Should it be orphaned?
> 
> (I got a bounce from Shaohua address)

I process the patch. Sorry for the delay.

Song

> 
>> 
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>> ---
>> drivers/md/md.c | 6 +-----
>> 1 file changed, 1 insertion(+), 5 deletions(-)
>> 
>> diff --git a/drivers/md/md.c b/drivers/md/md.c
>> index 24638ccedce4..3f1252440ad0 100644
>> --- a/drivers/md/md.c
>> +++ b/drivers/md/md.c
>> @@ -3664,11 +3664,7 @@ int strict_strtoul_scaled(const char *cp, unsigned long *res, int scale)
>> 		return -EINVAL;
>> 	if (decimals < 0)
>> 		decimals = 0;
>> -	while (decimals < scale) {
>> -		result *= 10;
>> -		decimals ++;
>> -	}
>> -	*res = result;
>> +	*res = result * int_pow(10, scale - decimals);
>> 	return 0;
>> }
>> 
>> -- 
>> 2.20.1
>> 
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 





[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux