On Mon, Jun 10, 2019 at 7:13 PM Xiao Ni <xni@xxxxxxxxxx> wrote: > > > > On 06/07/2019 12:36 AM, Song Liu wrote: > > On Tue, May 28, 2019 at 5:42 AM Xiao Ni <xni@xxxxxxxxxx> wrote: > >> In d5d885fd(md: introduce new personality funciton start()) it splits the init > >> job to two parts. The first part run() does the jobs that do not require the > >> md threads. The second part start() does the jobs that require the md threads. > > nit: checkpatch.pl complains > > > > WARNING: Possible unwrapped commit description (prefer a maximum 75 > > chars per line) > > #57: > > In d5d885fd(md: introduce new personality funciton start()) it splits the init > > > > I fixed this in my tree, so no need to resend. > > > >> Now it just does run() in adding new journal device. It needs to do the second > >> part start() too. > >> > >> Fixes: f6b6ec5cfac(raid5-cache: add journal hot add/remove support) > > Shall we say Fixes d5d885fd(md: introduce new personality funciton > > start()) here? > > Or do we really need the fix to earlier versions with f6b6ec5cfac? > Hi Song > > You are right. It's better to put d5d885fd in the Fixes line. > > Regards > Xiao Thanks Xiao! I will modify the commit log. Song
