Re: [PATCH 5/7] md: mark md_cluster_mod static

[Guoqing Jiang <gqjiang@xxxxxxxx>]

On 4/5/19 12:56 AM, Christoph Hellwig wrote:
> Sparse complains that it has no external declaration, and it turns out
> that it is never even used outside of md.c.  So just mark it static
> and drop the export.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
>   drivers/md/md.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index d1d7d20592af..3cd662c2863c 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -88,8 +88,7 @@ static struct kobj_type md_ktype;
>   
>   struct md_cluster_operations *md_cluster_ops;
>   EXPORT_SYMBOL(md_cluster_ops);
> -struct module *md_cluster_mod;
> -EXPORT_SYMBOL(md_cluster_mod);
> +static struct module *md_cluster_mod;
>   
>   static DECLARE_WAIT_QUEUE_HEAD(resync_wait);
>   static struct workqueue_struct *md_wq;

Acked-by: Guoqing Jiang <gqjiang@xxxxxxxx>

Thanks,
Guoqing