Re: [PATCH] md:MD_CLOSING needs to be cleared after called md_set_readonly or do_md_stop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Neil,

On Mon, Mar 18, 2019 at 12:58 AM NeilBrown <neilb@xxxxxxxx> wrote:
>
> On Sun, Mar 17 2019, Alexander Lyakas wrote:
>
> > Hi Zhilong Liu, Shaohua Li,
> >
> > In case of do_md_stop(), when we want to stop and disassemble the
> > array, why are we clearing MD_CLOSING? Then, after clearing this flag,
> > md_open will succeed. So MD_CLOSING flag is not serving its purpose,
> > to my understanding. How can we prevent md_open() to succeed after
> > do_md_stop()?
>
> If you want to understand MD_CLOSING, I suggest that you look through
> the "git log" history to see the comments in the comment that introduced
> or changed the flag.
>
> We don't want to prevent md_open() from succeeding after do_md_stop().
> We only want to block it while do_md_stop() is completing its task.
>

Thanks for your response. I found the previous MD_CLOSING commit in
the git history, and it's clear now.

> BTW Shaohua is no longer with us https://lwn.net/Articles/775861/
I apologize. I did not know that.

Thanks,
Alex.



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux