On Thu, Dec 6, 2018 at 1:41 PM Jes Sorensen <jsorensen@xxxxxx> wrote:
>
> On 11/6/18 9:27 AM, Gioh Kim wrote:
> > Before updating superblock of slave disks, desired_state value
> > is set for the target state of the slave disks. But it forgets
> > to check MD_DISK_FAILFAST and MD_DISK_WRITEMOSTLY flags. Then
> > start_arrays() calls ADD_NEW_DISK ioctl-call and pass the state
> > without MD_DISK_FAILFAST and MD_DISK_WRITEMOSTLY.
> >
> > Currenlty it does not generate any problem because kernel does not
> > care MD_DISK_FAILFAST or MD_DISK_WRITEMOSTLY flags.
> >
> > Signed-off-by: Gioh Kim <gi-oh.kim@xxxxxxxxxxxxxxxx>
> > ---
> > Assemble.c | 3 +++
> > 1 file changed, 3 insertions(+)
>
> Applied!
>
> Thanks!
> Jes
>
Hi Jes,
For your information, I am attaching my test script and the result on
my desktop.
mdadm version is 4.1 and commit 20e8fe52e7190b3ffda127566852eac2eb7fa1f7.
gohkim@ws00837:~/work/tools/mdadm-mainstream$ cat a.sh
if [ -b "/dev/md111" ]; then
./mdadm -S /dev/md111
fi
./mdadm -C /dev/md111 --failfast -l1 -n2 /dev/ram0 /dev/ram1
./mdadm /dev/md111 --fail /dev/ram0
./mdadm /dev/md111 --remove /dev/ram0
./mdadm -S /dev/md111
./mdadm -A /dev/md111 /dev/ram0 /dev/ram1
if [ -b "/dev/md111" ]; then
./mdadm -D /dev/md111
echo "Succeed to create md111"
else
echo "Fail to create md111"
fi
gohkim@ws00837:~/work/tools/mdadm-mainstream$ git describe
mdadm-4.0-316-g20e8fe5
gohkim@ws00837:~/work/tools/mdadm-mainstream$ sudo bash a.sh
[sudo] password for gohkim:
mdadm: stopped /dev/md111
mdadm: /dev/ram0 appears to be part of a raid array:
level=raid1 devices=2 ctime=Thu Dec 6 12:56:05 2018
mdadm: Note: this array has metadata at the start and
may not be suitable as a boot device. If you plan to
store '/boot' on this device please ensure that
your boot-loader understands md/v1.x metadata, or use
--metadata=0.90
mdadm: /dev/ram1 appears to be part of a raid array:
level=raid1 devices=2 ctime=Thu Dec 6 12:56:05 2018
Continue creating array? y
mdadm: Fail create md111 when using /sys/module/md_mod/parameters/new_array
mdadm: Defaulting to version 1.2 metadata
mdadm: array /dev/md111 started.
mdadm: set /dev/ram0 faulty in /dev/md111
mdadm: hot removed /dev/ram0 from /dev/md111
mdadm: stopped /dev/md111
mdadm: Fail create md111 when using /sys/module/md_mod/parameters/new_array
mdadm: ignoring /dev/ram1 as it reports /dev/ram0 as failed
mdadm: /dev/md111 assembled from 1 drive - need all 2 to start it (use
--run to insist).
mdadm: Array associated with md device /dev/md111 does not exist.
Succeed to create md111
gohkim@ws00837:~/work/tools/mdadm-mainstream$ cat /proc/mdstat
Personalities : [raid1]
unused devices: <none>
--
GIOH KIM
Linux Kernel Entwickler
1&1 IONOS Cloud GmbH
Greifswalder Str. 207
D - 10405 Berlin
Tel: +49 176 2697 8962
Fax: +49 30 577 008 299
Email: gi-oh.kim@xxxxxxxxxxxxxxx
URL: https://www.ionos.com
Sitz der Gesellschaft: Berlin
Registergericht: Amtsgericht Charlottenburg, HRB 125506 B
Geschäftsführer: Achim Weiss, Matthias Steinberg, Christoph Steffens
