Re: [PATCH V10 11/19] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ming Lei <ming.lei@xxxxxxxxxx>
Subject: Re: [PATCH V10 11/19] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages()
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 16 Nov 2018 14:46:45 +0100
Cc: Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Dave Chinner <dchinner@xxxxxxxxxx>, Kent Overstreet <kent.overstreet@xxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, dm-devel@xxxxxxxxxx, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Shaohua Li <shli@xxxxxxxxxx>, linux-raid@xxxxxxxxxxxxxxx, linux-erofs@xxxxxxxxxxxxxxxx, David Sterba <dsterba@xxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, "Darrick J . Wong" <darrick.wong@xxxxxxxxxx>, linux-xfs@xxxxxxxxxxxxxxx, Gao Xiang <gaoxiang25@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, Coly Li <colyli@xxxxxxx>, linux-bcache@xxxxxxxxxxxxxxx, Boaz Harrosh <ooo@xxxxxxxxxxxxxxx>, Bob Peterson <rpeterso@xxxxxxxxxx>, cluster-devel@xxxxxxxxxx
In-reply-to: <20181115085306.9910-12-ming.lei@redhat.com>
References: <20181115085306.9910-1-ming.lei@redhat.com> <20181115085306.9910-12-ming.lei@redhat.com>
User-agent: Mutt/1.5.17 (2007-11-01)

> -	bio_for_each_segment_all(bv, bio, i) {
> +	for (i = 0, bv = bio->bi_io_vec; i < bio->bi_vcnt; bv++) {

This really needs a comment.  Otherwise it looks fine to me.

Follow-Ups:
- Re: [PATCH V10 11/19] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages()
  - From: Ming Lei

References:
- [PATCH V10 00/19] block: support multi-page bvec
  - From: Ming Lei
- [PATCH V10 11/19] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages()
  - From: Ming Lei

Prev by Date: Re: [PATCH V10 09/19] block: introduce bio_bvecs()
Next by Date: Re: [PATCH V10 13/19] iomap & xfs: only account for new added page
Previous by thread: Re: [PATCH V10 11/19] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages()
Next by thread: Re: [PATCH V10 11/19] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages()
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID Wiki] [ATA RAID] [Linux SCSI Target Infrastructure] [Linux Block] [Linux IDE] [Linux SCSI] [Linux Hams] [Device Mapper] [Device Mapper Cryptographics] [Kernel] [Linux Admin] [Linux Net] [GFS] [RPM] [git] [Yosemite Forum]