Re: [PATCH] mapfile: set *mapp to NULL after map_free

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/18/2018 09:40 PM, Guoqing Jiang wrote:
> We can see "double free or corruption" with below steps
> as reported by Mariusz:
> 
> export IMSM_NO_PLATFORM=1
> export IMSM_DEVNAME_AS_SERIAL=1
> mdadm --zero-super /dev/sd*
> mdadm -C /dev/md/imsm -n2 -eimsm /dev/sdb /dev/sdc --run
> mdadm -C /dev/md/r1 -n2 -z15G -eimsm /dev/sdb /dev/sdc -l1 --run --assume-clean
> mdadm -f /dev/md126 /dev/sdb
> mdadm -Ss
> 
> It is caused by Manage_stop calls map_remove and map_unlock,
> but *mapp is not set to NULL after map_remove -> map_free,
> so map_unlock will call map_free again.
> 
> Reported-by: Tkaczyk Mariusz <mariusz.tkaczyk@xxxxxxxxx>
> Tested-by: Tkaczyk Mariusz <mariusz.tkaczyk@xxxxxxxxx>
> Signed-off-by: Guoqing Jiang <gqjiang@xxxxxxxx>

Applied!

Anything else we need to get in before we start thinking about freezing 4.1?

Thanks,
Jes

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux