Re: [PATCH 2/2] Coverity: 289702: Fix resource leak - free avail

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/14/2018 02:04 PM, Wol wrote:
> Signed-off-by: Wol <anthony@xxxxxxxxxxxxxxx>
> ---
>  Assemble.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Assemble.c b/Assemble.c
> index 0a7ab6f..ed21e25 100644
> --- a/Assemble.c
> +++ b/Assemble.c
> @@ -1853,6 +1853,7 @@ try_again:
>  	if (rv == 1 && !pre_exist)
>  		ioctl(mdfd, STOP_ARRAY, NULL);
>  	free(devices);
> +        free(avail);

Another formatting problem, the code use tabs for indentations, not spaces.

Could you also try and write a slightly longer commit message.

Thanks,
Jes

>  out:
>  	map_unlock(&map);
>  	if (rv == 0) {
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux