On 06/11/2018 05:03 AM, Guoqing Jiang wrote: > 1. There are some places which didn't free map as > discovered by coverity. > > CID 289661 (#1 of 1): Resource leak (RESOURCE_LEAK)12. leaked_storage: Variable mapl going out of scope leaks the storage it points to. > CID 289619 (#3 of 3): Resource leak (RESOURCE_LEAK)63. leaked_storage: Variable map going out of scope leaks the storage it points to. > CID 289618 (#1 of 1): Resource leak (RESOURCE_LEAK)26. leaked_storage: Variable map going out of scope leaks the storage it points to. > CID 289607 (#1 of 1): Resource leak (RESOURCE_LEAK)41. leaked_storage: Variable map going out of scope leaks the storage it points to. > > 2. If we call map_by_* inside a loop, then map_free > should be called in the same loop, and it is better > to set map to NULL after free. > > 3. And map_unlock is always called with map_lock, > if we don't call map_remove before map_unlock, > then the memory (allocated by map_lock -> map_read > -> map_add -> xmalloc) could be leaked. So we > need to free it in map_unlock as well. > > Signed-off-by: Guoqing Jiang <gqjiang@xxxxxxxx> Applied, thanks! Jes -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
