Re: [PATCH 1/4] imsm: change reserved space to 4MB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/12/2018 04:08 AM, Mariusz Dabrowski wrote:
> On 04/10/2018 10:13 PM, Jes Sorensen wrote:
>> On 04/05/2018 07:38 AM, Mariusz Dabrowski wrote:
>>> Due to compatibility to the  newest OROM, imsm reserved space has to be
>>> expanded to 4MB.
>>>
>>> Signed-off-by: Mariusz Dabrowski <mariusz.dabrowski@xxxxxxxxx>
>>> ---
>>>  super-intel.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/super-intel.c b/super-intel.c
>>> index fb1b6936..52011e5b 100644
>>> --- a/super-intel.c
>>> +++ b/super-intel.c
>>> @@ -88,8 +88,8 @@
>>>  #define MPB_ATTRIB_IGNORED        (MPB_ATTRIB_NEVER_USE)
>>>
>>>  #define MPB_SECTOR_CNT 2210
>>> -#define IMSM_RESERVED_SECTORS 4096
>>> -#define NUM_BLOCKS_DIRTY_STRIPE_REGION 2056
>>> +#define IMSM_RESERVED_SECTORS 8192
>>> +#define NUM_BLOCKS_DIRTY_STRIPE_REGION 2048
>>>  #define SECT_PER_MB_SHIFT 11
>>>  #define MAX_SECTOR_SIZE 4096
>>>  #define MULTIPLE_PPL_AREA_SIZE_IMSM (1024 * 1024) /* Size of the whole
>>
>> Before I apply this, can you please confirm that this will not break
>> existing arrays?
> 
> Hi Jes,
> 
> Before sending those patches we have performed several tests for
> compatibility of old arrays with new mdadm and we haven't seen any
> issues. Increased reserved space applies to new arrays and it won't be
> changed for existing arrays. Only blocks_per_member and num_data_stripes
> will be updated by reshape.

Hi Mariusz,

Sounds great, thanks for clarifying this!

All 4 applied!

Thanks,
Jes

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux