In misc_list(), case KillOpt, the return values from the Kill() function are saved, but soon after cleared with a bitwise OR assignment. Expose these return values to the user, indicating success of the zeroing operation or an error value to accompany the error message printed to the console. Before: # mdadm -C /dev/md0 -l 1 -n 2 -e 1.2 /dev/sda /dev/sdb mdadm: array /dev/md0 started. # mdadm --zero-superblock /dev/sdb mdadm: Couldn't open /dev/sdb for write - not zeroing # echo $? 0 After: # mdadm -C /dev/md0 -l 1 -n 2 -e 1.2 /dev/sda /dev/sdb mdadm: array /dev/md0 started. # mdadm --zero-superblock /dev/sdb mdadm: Couldn't open /dev/sdb for write - not zeroing # echo $? 2 Signed-off-by: John Pittman <jpittman@xxxxxxxxxx> --- mdadm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mdadm.c b/mdadm.c index afc3015..77b80fa 100644 --- a/mdadm.c +++ b/mdadm.c @@ -1937,7 +1937,6 @@ static int misc_list(struct mddev_dev *devlist, rv |= Kill(dv->devname, NULL, c->force, v, 0); v = -1; } while (rv == 0); - rv &= ~2; } continue; case 'Q': -- 2.7.5 -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
