On 17/11/23 上午8:42, 彭良彦 wrote:
> If the backing device hasn't been detached due to exceptional stop
> like power outage, the BDEV_STATE in super block can't be reset,
> it will fail to register this backing device in next time, but the
> opened bdev will be hold, this makes the backing device unaccessable
> because of FMODE_EXCL until reboot.
>
> Signed-off-by: Liangyan Peng <liangyan.ply@xxxxxxxxxxxxxxx>
> ---
> drivers/md/bcache/super.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 66669c8f4161..0b95a594c12e 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -1174,9 +1174,7 @@ static void register_bdev(struct cache_sb *sb, struct page *sb_page,
> list_for_each_entry(c, &bch_cache_sets, list)
> bch_cached_dev_attach(dc, c);
>
> - if (BDEV_STATE(&dc->sb) == BDEV_STATE_NONE ||
> - BDEV_STATE(&dc->sb) == BDEV_STATE_STALE)
> - bch_cached_dev_run(dc);
> + bch_cached_dev_run(dc);
>
> return;
> err:
> @@ -1982,7 +1980,16 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr,
> goto err_close;
>
> if (SB_IS_BDEV(sb)) {
> - struct cached_dev *dc = kzalloc(sizeof(*dc), GFP_KERNEL);
> + struct cached_dev *dc = NULL;
> +
> + if (BDEV_STATE(sb) != BDEV_STATE_NONE &&
> + BDEV_STATE(sb) != BDEV_STATE_STALE) {
> + blkdev_put(bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL);
> + err = "invalid super block";
> + pr_info("Failed to register %s: %s", path, err);
> + goto out;
> + }
> + dc = kzalloc(sizeof(*dc), GFP_KERNEL);
> if (!dc)
> goto err_close;
>
ping?��.n��������+%������w��{.n�����{����w��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
