On 11/22/2017 10:10 PM, Zhilong Liu wrote: > To fix the commit: 1b21c449e6f2 > (mdadm/grow: adding a test to ensure resize was required) The correct way to put this in is: Fixes: 1b21c449e6f2 ("mdadm/grow: adding a test to ensure resize was required") I fixed it up this time and applied the patch, but please comply with the normal rules next time. Thanks, Jes > s->size > 1 : s->size is '1' when '--grow --size max' > parameter is specified, so correct this test here. > > Signed-off-by: Zhilong Liu <zlliu@xxxxxxxx> > > resend it due to the missed patch: > [PATCH v3] mdadm/grow: adding a test to ensure resize was required > > Grow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Grow.c b/Grow.c > index 80176e3..3ee015b 100644 > --- a/Grow.c > +++ b/Grow.c > @@ -1815,7 +1815,7 @@ int Grow_reshape(char *devname, int fd, > return 1; > } > > - if (array.level > 1 && s->size > 0 && > + if (array.level > 1 && s->size > 1 && > (array.chunk_size / 1024) > (int)s->size) { > pr_err("component size must be larger than chunk size.\n"); > return 1; > -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html