Re: [mdadm PATCH] mdadm: make create clustered raid10 possible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/24/2017 04:05 PM, NeilBrown wrote:
On Tue, Oct 24 2017, Guoqing Jiang wrote:

This change to make we can create a clustered
raid10 array as well.

Signed-off-by: Guoqing Jiang <gqjiang@xxxxxxxx>
---
  mdadm.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mdadm.c b/mdadm.c
index 7cdcdba7c652..60d80e0103f4 100644
--- a/mdadm.c
+++ b/mdadm.c
@@ -1542,8 +1542,9 @@ int main(int argc, char *argv[])
  				break;
  			}
- if (s.level != 1) {
-				pr_err("--bitmap=clustered is currently supported with RAID mirror only\n");
+			if (s.level != 1 && s.level != 10) {
+				pr_err("--bitmap=clustered is currently "
+				       "supported with raid1/10 only\n");


Please don't wrap strings.  It makes it hard to search for them.
Long line might be bad, but wrapped strings are worse.

Personally I actually prefer the wrapped strings over the long lines, but given the kernel consensus is not to wrap, I apply that rule to mdadm as well.

Cheers,
Jes


--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux