On 19/09/17 14:16, Xiao Ni wrote: > > > ----- Original Message ----- >> From: "Paul Menzel" <pmenzel@xxxxxxxxxxxxx> >> To: "Xiao Ni" <xni@xxxxxxxxxx> >> Cc: jsorensen@xxxxxx, zlliu@xxxxxxxx, linux-raid@xxxxxxxxxxxxxxx >> Sent: Tuesday, September 19, 2017 6:24:52 PM >> Subject: Re: [mdadm PATCH 1/1] Fix a building error >> >> Dear Xiao, >> >> >> Please find some comments and nits below. > > Hi Paul > > Thanks for these suggestions. > >> >> On 09/19/17 12:14, Xiao Ni wrote: >>> In s390 platform, it gives a building error: >> >> s/building error/build error/ >> >> Maybe: On s390 platform the build fails with the error below. > > Ok. c/On s390/On the s390/ >> >>> Manage.c: In function 'Manage_subdevs': >>> Manage.c:1502:5: error: passing argument 3 of 'fstat_is_blkdev' from >>> incompatible pointer type [-Werror] >>> fstat_is_blkdev(tfd, dv->devname, &rdev); >>> ^ >>> In file included from Manage.c:25:0: >>> mdadm.h:1446:12: note: expected 'dev_t *' but argument is of type 'long >>> unsigned int *' >>> >>> It was introduced by 0a6bff09 and add a temp variable to fix this. >> >> Maybe: It is introduced by commit 0a6bff09 (mdadm/util: unify fstat >> checking blkdev into function). So use a temp variable to fix this. > > Yes, the word so is better. Sorry for my pool English. It's not bad ... :-) revert with c/is/was/ Personally I probably wouldn't abbreviate "temporary", but that's a matter of taste. >> >>> >>> Signed-off-by: Xiao Ni <xni@xxxxxxxxxx> >>> --- Cheers, Wol -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
