On Wed, Jul 19, 2017 at 01:00:45PM +0000, Ofer Heifetz wrote: > Hi, > > I have a question regarding raid5 built using group_thread and async_tx, from code (v4.4 and even v4.12) I see that only raid5d invokes async_tx_issue_pending_all, shouldn't the raid5_do_work also invoke this API to issue > all pending requests to HW? > > I am assuming that there is no sync mechanism between the raid5d and the raid5_do_work, correct me if I am wrong. Can't remember why we don't call async_tx_issue_pending_all in raid5_do_work, it shouldn't harm. In practice, I doubt calling it makes a change, because when workers are running, raid5d are running too. Did you benchmark it? Thanks, Shaohua -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
