On Wed, Jul 12, 2017 at 02:16:08AM -0700, Christoph Hellwig wrote: > On Wed, Jul 12, 2017 at 04:29:12PM +0800, Ming Lei wrote: > > We will support multipage bvec soon, so initialize bvec > > table using the standardy way instead of writing the > > talbe directly. Otherwise it won't work any more once > > multipage bvec is enabled. > > It seems to me like these callsites also should use bio_init > instead of bio_reset to get a clean slate (and eventually > phase out bio_reset), which should probably got into > the helper as well. E.g. instead of pretending to preserve > things we should simply build a new bio here. At least for resetting bvec table, bio_reset() is enough, so I think changing to bio_init() should belong to another topic, :-) Thanks, Ming -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html