Re: [PATCH] md: uuid debug statement now in processor byte order.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 24, 2017 at 10:16:27AM -0700, Kyungchan Koh wrote:
> Previously, the uuid debug statements were printed in little-endian
> format, which wasn't consistent in machines that might not be in
> little-endian byte order. With this change, the output will be
> consistent for all machines with different byte-ordering.

applied, thanks!
 
> Signed-off-by: Kyungchan Koh <kkc6196@xxxxxx>
> ---
>  drivers/md/bitmap.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
> index bf7419a..f4eace5 100644
> --- a/drivers/md/bitmap.c
> +++ b/drivers/md/bitmap.c
> @@ -485,10 +485,10 @@ void bitmap_print_sb(struct bitmap *bitmap)
>  	pr_debug("         magic: %08x\n", le32_to_cpu(sb->magic));
>  	pr_debug("       version: %d\n", le32_to_cpu(sb->version));
>  	pr_debug("          uuid: %08x.%08x.%08x.%08x\n",
> -		 *(__u32 *)(sb->uuid+0),
> -		 *(__u32 *)(sb->uuid+4),
> -		 *(__u32 *)(sb->uuid+8),
> -		 *(__u32 *)(sb->uuid+12));
> +		 le32_to_cpu(*(__u32 *)(sb->uuid+0)),
> +		 le32_to_cpu(*(__u32 *)(sb->uuid+4)),
> +		 le32_to_cpu(*(__u32 *)(sb->uuid+8)),
> +		 le32_to_cpu(*(__u32 *)(sb->uuid+12)));
>  	pr_debug("        events: %llu\n",
>  		 (unsigned long long) le64_to_cpu(sb->events));
>  	pr_debug("events cleared: %llu\n",
> -- 
> 2.9.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux